Skip to content

update new relic#2759

Open
jzbahrai wants to merge 1 commit intomainfrom
task/update-newrelic
Open

update new relic#2759
jzbahrai wants to merge 1 commit intomainfrom
task/update-newrelic

Conversation

@jzbahrai
Copy link
Collaborator

Summary | Résumé

  1. Update newrelic
  2. Update the dockerfile with errors due to yarn

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

TODO: Fill in test instructions for the reviewer.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

Copilot AI review requested due to automatic review settings February 10, 2026 17:41
@jzbahrai jzbahrai requested a review from jimleroyer as a code owner February 10, 2026 17:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates New Relic and adjusts the devcontainer Dockerfile to fix Yarn APT repository key/repo setup issues on Debian Bookworm.

Changes:

  • Bump newrelic Python dependency from 11.0.0 to 11.0.1
  • Add Yarn APT repository keyring + source list setup steps in the devcontainer Dockerfile

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
pyproject.toml Updates the pinned New Relic version
.devcontainer/Dockerfile Adds Yarn repo keyring/source configuration for Bookworm

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mkdir -p /etc/apt/keyrings && \
curl -fsSL "https://dl.yarnpkg.com/debian/pubkey.gpg" | gpg --dearmor --yes -o /etc/apt/keyrings/yarn-archive-keyring.gpg && \
echo "deb [signed-by=/etc/apt/keyrings/yarn-archive-keyring.gpg] https://dl.yarnpkg.com/debian/ stable main" > /etc/apt/sources.list.d/yarn.list && \
apt-get update && apt-get clean -y && rm -rf /var/lib/apt/lists/*
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apt-get clean does not accept -y and may fail the Docker build with an 'option not understood' error. Drop the -y flag (or remove apt-get clean entirely if rm -rf /var/lib/apt/lists/* is already used).

Copilot uses AI. Check for mistakes.
apt-get update && \
apt-get install -y --no-install-recommends gnupg dirmngr curl ca-certificates && \
mkdir -p /etc/apt/keyrings && \
curl -fsSL "https://dl.yarnpkg.com/debian/pubkey.gpg" | gpg --dearmor --yes -o /etc/apt/keyrings/yarn-archive-keyring.gpg && \
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build currently trusts whatever key is returned by the URL at build time. To reduce supply-chain risk, verify the downloaded key before installing it (e.g., check the expected fingerprint in the Dockerfile and fail if it doesn’t match).

Suggested change
curl -fsSL "https://dl.yarnpkg.com/debian/pubkey.gpg" | gpg --dearmor --yes -o /etc/apt/keyrings/yarn-archive-keyring.gpg && \
set -e; \
YARN_EXPECTED_FPR="72ECF46A56B4AD39C907BBB71646B01B86E50310"; \
curl -fsSL "https://dl.yarnpkg.com/debian/pubkey.gpg" -o /tmp/yarn-pubkey.gpg; \
YARN_ACTUAL_FPR="$(gpg --dry-run --import --import-options show-only --with-colons /tmp/yarn-pubkey.gpg | awk -F: '/^fpr:/ {print $10; exit}')"; \
if [ "$YARN_ACTUAL_FPR" != "$YARN_EXPECTED_FPR" ]; then \
echo "ERROR: Yarn GPG key fingerprint mismatch: expected $YARN_EXPECTED_FPR but got $YARN_ACTUAL_FPR" >&2; \
exit 1; \
fi; \
gpg --dearmor --yes -o /etc/apt/keyrings/yarn-archive-keyring.gpg /tmp/yarn-pubkey.gpg && \
rm -f /tmp/yarn-pubkey.gpg && \

Copilot uses AI. Check for mistakes.
mkdir -p /etc/apt/keyrings && \
curl -fsSL "https://dl.yarnpkg.com/debian/pubkey.gpg" | gpg --dearmor --yes -o /etc/apt/keyrings/yarn-archive-keyring.gpg && \
echo "deb [signed-by=/etc/apt/keyrings/yarn-archive-keyring.gpg] https://dl.yarnpkg.com/debian/ stable main" > /etc/apt/sources.list.d/yarn.list && \
apt-get update && apt-get clean -y && rm -rf /var/lib/apt/lists/*
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two apt-get update calls in the same layer. If no packages are installed from the Yarn repo in this step, the second update is unnecessary overhead; consider removing it and only running apt-get update immediately before any later apt-get install that depends on the Yarn repo.

Suggested change
apt-get update && apt-get clean -y && rm -rf /var/lib/apt/lists/*
apt-get clean -y && rm -rf /var/lib/apt/lists/*

Copilot uses AI. Check for mistakes.
@jzbahrai jzbahrai closed this Feb 10, 2026
@jzbahrai jzbahrai reopened this Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants