feat: Add error handling and input validation to Rust core (#82)#88
Open
ada-cinar wants to merge 1 commit into
Open
feat: Add error handling and input validation to Rust core (#82)#88ada-cinar wants to merge 1 commit into
ada-cinar wants to merge 1 commit into
Conversation
- Add PyResult return types to all public functions - Add input validation (empty strings, zero min_root_length) - Return Pythonic ValueError exceptions instead of panics - Add comprehensive error handling tests (16 test cases) - Improve function documentation with error specifications Benefits: - Better debugging experience with clear error messages - Graceful handling of edge cases - Follows PyO3 best practices - Type-safe error propagation Fixes #82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds proper error handling and input validation to all Rust core functions, replacing panics with Pythonic ValueError exceptions.
Changes
✅ Error Handling:
#[pyfunction]signatures to returnPyResult<T>PyValueErrorexceptions for invalid input✅ Input Validation:
fast_normalize,lookup_lemma,strip_suffixesmin_root_lengthvalidation instrip_suffixes_validatedtokenize_with_offsets(returns empty list)✅ Testing:
✅ Documentation:
Benefits
Testing
Closes
Closes #82
Related