fix: Add missing Tokenizer and TokenizationError imports#80
Open
ada-cinar wants to merge 1 commit into
Open
Conversation
Closes #76 - Added Tokenizer (type alias) to public API imports - Added TokenizationError (exception class) to public API imports - Both were already declared in __all__ but not imported - Users can now successfully import them: from durak import Tokenizer, TokenizationError
Member
|
No, Tokenizer should be abstract level returning error imports as well w/o extra specification in import path |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #76
Added missing imports for
TokenizerandTokenizationErrortopython/durak/__init__.py.Changes
Tokenizer(type alias) to import statementTokenizationError(exception class) to import statement__all__but not imported from.tokenizerImpact
Users can now successfully import:
Testing
Verified with:
PYTHONPATH=python python3 -c "from durak import Tokenizer, TokenizationError"Type