Fix missing Rust function implementations causing build failure#126
Draft
Copilot wants to merge 4 commits into
Draft
Fix missing Rust function implementations causing build failure#126Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
7 tasks
Co-authored-by: fbkaragoz <59958216+fbkaragoz@users.noreply.github.com>
- Add get_build_info() and get_resource_info() implementations in src/lib.rs - Add build.rs to capture Rust version at compile time - Fix unused import warnings (remove serde Deserialize/Serialize) - Fix clippy warning in morphotactics.rs (empty line after doc comment) - Fix PyObject deprecation warning (use Py<PyAny>) - Fix Python linting errors in info.py and generate_resource_metadata.py - Update type stubs to use dict instead of Dict - Fix test assertion to match actual output format - All 26 resource versioning tests now pass Co-authored-by: fbkaragoz <59958216+fbkaragoz@users.noreply.github.com>
- Reformat note field to single line (no embedded newlines) - Add intermediate variable for better code organization - All tests still pass Co-authored-by: fbkaragoz <59958216+fbkaragoz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add resource versioning and reproducibility tracking
Fix missing Rust function implementations causing build failure
Jan 28, 2026
fbkaragoz
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR registered
get_build_info()andget_resource_info()in the Python module but never implemented them in Rust, causing compilation to fail.Changes
Implemented missing Rust functions (
src/lib.rs):get_build_info()- Parses embedded metadata.json, returns build info as HashMapget_resource_info()- Converts JSON resource metadata to Python dict via PyO3build.rsto capture rustc version at compile timeFixed linting issues:
serde::{Deserialize, Serialize}importsmorphotactics.rsPyObjecttoPy<PyAny>Dict→dictinfo.pyandgenerate_resource_metadata.pyFixed test:
Usage
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.