fix: Update benchmark script to use process_text API (#51)#109
Open
ada-cinar wants to merge 1 commit into
Open
fix: Update benchmark script to use process_text API (#51)#109ada-cinar wants to merge 1 commit into
ada-cinar wants to merge 1 commit into
Conversation
- Replace deprecated string-based Pipeline initialization - Use process_text convenience function for pipeline benchmark - Fixes TypeError: 'str' object is not callable error Closes #51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The benchmark script was using the old string-based Pipeline API:
This caused a
TypeError: 'str' object is not callablebecause the Pipeline class expects callable objects, not strings.Solution
Updated benchmark #4 to use the
process_textconvenience function instead:This uses the current API and should run without errors.
Testing
python3 -m py_compile)maturin develop(CI will verify)Closes #51