Skip to content

fix(import)!: always generate classes with version suffixes #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shinebayar-g wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Draft

fix(import)!: always generate classes with version suffixes #2728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5cb339
fix!: always generate classes with version suffixes, closes cdk8s-tea…
shinebayar-g Sep 14, 2024
aa28f3a
Merge branch '2.x' into fix-crd-versioning
shinebayar-g Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/import/crd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,7 @@ export class CustomResourceDefinition {
for (let i = 0; i < this.versions.length; i++) {

const version = this.versions[i];

// to preseve backwards compatiblity, only append a suffix for
// the second version onwards.
const suffix = i === 0 ? '' : toPascalCase(version.name);

const suffix = toPascalCase(version.name);
const types = new TypeGenerator({});

generateConstruct(types, {
Expand Down
Loading