Merged
Conversation
…iguration
- Changed the request handling method in server.ts from `app.all('*', ...)` to `app.use(...)` for better middleware integration.
- Added `moduleResolution: "node"` to tsconfig.server.json for improved module resolution.
- Updated dependencies in package.json: upgraded `body-parser` to version 2.2.0, `express` to version 5.0.0, and `@types/express` to version 5.0.0 for compatibility with the latest Express features.
Updated the typescript-eslint dependency in package.json and package-lock.json to version 8.58.1, ensuring compatibility with the latest TypeScript features and improvements.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+32
to
34
| app.use((req, res) => { | ||
| void nextRequestHandler(req, res); | ||
| }); |
There was a problem hiding this comment.
Critical error handling issue: Using void on the promise returned by nextRequestHandler will cause unhandled promise rejections if the handler throws an error or rejects. This will crash the Node.js process in production.
In Express 5, async errors need to be properly handled. The fix should either:
app.use((req, res, next) => {
nextRequestHandler(req, res).catch(next);
});Or if using async/await:
app.use(async (req, res, next) => {
try {
await nextRequestHandler(req, res);
} catch (error) {
next(error);
}
});
Suggested change
| app.use((req, res) => { | |
| void nextRequestHandler(req, res); | |
| }); | |
| app.use((req, res, next) => { | |
| nextRequestHandler(req, res).catch(next); | |
| }); |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.