fix(flamegraph): use root name index#252
Open
pkurunner wants to merge 1 commit into
Open
Conversation
Signed-off-by: yeyangyi <2501210756@stu.pku.edu.cn>
pkurunner
force-pushed
the
codex/fix-flamegraph-root-name-20260621
branch
from
fee78db to
4e0a76c
Compare
Contributor
Author
|
CI note: PR name lint and Build/Lint passed. Ubuntu 22.04 VM failed before tests while installing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LevelsToTreewas reading the root label fromValues[0], but that slot is the start offset. Child nodes already read names fromNameOffest; the root should do the same, otherwise a root whose name index is not zero gets labeled incorrectly.Testing:
gofmt -w internal/flamegraph/flamegraph.go internal/flamegraph/flamegraph_test.goGOCACHE=.gocache-flamegraph go test ./internal/flamegraph