fix(cpusys): skip zero cpu stat deltas#247
Open
pkurunner wants to merge 1 commit into
Open
Conversation
Signed-off-by: yeyangyi <2501210756@stu.pku.edu.cn>
Contributor
Author
|
CI note: build/lint, PR name lint, ubuntu22 and ubuntu24 passed. The only red job is ubuntu20, and it failed in I do not have permission to rerun failed jobs from the fork, but the failure does not point to this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPUSys divides by the total
/proc/statdelta. If the sampler runs again before total ticks move forward, that delta is 0 and the tracer can panic.This just skips that interval and keeps the latest sample as the next baseline. The next tick will calculate from a real delta.
Testing: gofmt -w core/autotracing/cpusys.go
Not run locally:
go test ./core/autotracingon Windows hits Linux-only syscall/cgroup/BPF types;GOOS=linux GOARCH=amd64 go test -c ./core/autotracingis blocked by missing generated capnp transport types in my local snapshot.