feat(metrics): add wait_sum based exter wait rate#245
Open
zzzhang1127 wants to merge 1 commit into
Open
Conversation
Read wait_sum from cgroup cpu.stat and export wait_sum_exter_wait_rate using delta_wait_sum / (delta_wait_sum + delta_cpu_usage). Counter reset is guarded before subtraction. Requires kernel.sched_schedstats=1 for wait_sum in cpu.stat. Testing: - gofmt -w core/metrics/cpu_stat.go - GOFLAGS=-mod=mod go build with AppVersion ldflags - Docker dynamic: huatuo-bamai starts, cpu_stat registered, scrape success=1, no panic Closes ccfos#25 Co-authored-by: Cursor <cursoragent@cursor.com>
redsky110
reviewed
Jun 18, 2026
| metrics, metric.NewContainerGaugeData(container, "wait_rate", containerDataCache.waitrateHierarchy, "wait rate for the containers", nil), | ||
| metric.NewContainerGaugeData(container, "inner_wait_rate", containerDataCache.waitrateInner, "inner wait rate for the containers", nil), | ||
| metric.NewContainerGaugeData(container, "exter_wait_rate", containerDataCache.waitrateExter, "exter wait rate for the containers", nil), | ||
| metric.NewContainerGaugeData(container, "wait_sum_exter_wait_rate", containerDataCache.waitrateWaitSum, "exter wait rate from wait_sum and cpu usage (requires kernel.sched_schedstats=1)", nil), |
Contributor
There was a problem hiding this comment.
s /"exter wait rate from wait_sum and cpu usage (requires kernel.sched_schedstats=1)"/ "exter wait rate base on wait_sum (requires kernel.sched_schedstats=1)"
这样看起来好一些?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read wait_sum from cgroup cpu.stat and export wait_sum_exter_wait_rate using delta_wait_sum / (delta_wait_sum + delta_cpu_usage). Counter reset is guarded before subtraction.
Requires kernel.sched_schedstats=1 for wait_sum in cpu.stat.
Testing:
Closes #25