Skip to content

fix(memburst): validate sampling config#231

Open
pkurunner wants to merge 1 commit into
ccfos:mainfrom
pkurunner:codex/fix-memburst-config-validation-20260616
Open

fix(memburst): validate sampling config#231
pkurunner wants to merge 1 commit into
ccfos:mainfrom
pkurunner:codex/fix-memburst-config-validation-20260616

Conversation

@pkurunner

Copy link
Copy Markdown
Contributor

Summary

  • validate MemoryBurst sliding window, interval, and process dump limits before starting
  • return a clear error instead of panicking on zero or negative user config
  • add table-driven coverage for the validation helper

Testing

  • gofmt -w core/autotracing/memburst.go core/autotracing/memburst_config_test.go
  • Not run: GOOS=linux GOARCH=amd64 go test -c ./core/autotracing is blocked on a clean upstream snapshot by missing generated internal/toolstream/transport capnp types.

Signed-off-by: yeyangyi <2501210756@stu.pku.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant