Allow VeriReel runtime bindings in testing#1119
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prod_onlytoshared_safeverireeland instancestesting/prodWhy
PR #1118 added the missing VeriReel binding classifications, but the policy model disallows
prod_onlyfor testing targets. VeriReel uses the same binding keys for testing and prod, so the active policy needs a class allowed in both runtime classes while still tightly scoped by context and instance.Failure evidence after #1118 seed import: product-config dry-run for VeriReel testing private values still failed with
runtime_key_safety_failed, tracelaunchplane_req_fc7e3218b0fb456c8fb37cfa9fcf4e81.Validation
npx --yes prettier --check import-material/launchplane/seed-imports/catalog.jsonuv run python -m unittest tests.test_product_onboarding.ProductOnboardingTests.test_launchplane_seed_import_catalog_validates_contracts tests.test_product_onboarding.ProductOnboardingTests.test_launchplane_seed_import_script_requires_target_id_env tests.test_product_onboarding.ProductOnboardingTests.test_launchplane_seed_import_script_patches_provider_targets