Open
Conversation
10 tasks
Owner
|
Thanks! These platform-independent macros are long needed. We might need to find another solution eventually, but right now I'd value any kind of fiddling, possibly irrational to us but helping indent, that reduces the diff after scindent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MSVC-specific syntax issues
Proposed changes:
noreturn Function Declarations
noreturnfunction declarations to be compatible with MSVC compilerprintf-style Format String Validation
Improved aligned memory allocation and free
_aligned_malloc,_aligned_free, and_aligned_reallocon Windows.Windows Sleep Implementation
pthread.cfor sleep functionalitySleep()APIThese changes enable successful compilation on Windows using MSVC without requiring MinGW or clang-cl toolchains, while maintaining compatibility with other platforms.
Windows Build Instructions
To compile on Windows with MSVC:
cmake -G "Visual Studio 17 2022" -A x64struct sc_camerainsc_camera.h(cburstedde said this will be fiexd in the future 😄):