Skip to content

feat: 부원 일괄 비활성화 API 추가 및 온보딩 메일 파라미터 추가#119

Merged
BongSeongEun merged 1 commit into
devfrom
feat/addPaymentAPI/junmin
Jul 4, 2026
Merged

feat: 부원 일괄 비활성화 API 추가 및 온보딩 메일 파라미터 추가#119
BongSeongEun merged 1 commit into
devfrom
feat/addPaymentAPI/junmin

Conversation

@coom1222

@coom1222 coom1222 commented Jul 2, 2026

Copy link
Copy Markdown
Member

🎀 PR 유형

어떤 변경 사항이 있나요?

  • 새로운 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 코드에 영향을 주지 않는 변경사항(오타 수정, 탭 사이즈 변경, 변수명 변경)
  • 코드 리팩토링
  • 주석 추가 및 수정
  • 문서 수정
  • 테스트 추가, 테스트 리팩토링
  • 빌드 부분 혹은 패키지 매니저 수정
  • 파일 혹은 폴더명 수정
  • 파일 혹은 폴더 삭제

✨ 추가/수정 내용

🎊 PR Checklist

PR이 다음 요구 사항을 충족하는지 확인하세요.

  • 커밋 메시지 컨벤션에 맞게 작성했습니다. Commit message convention 참고 (Ctrl + 클릭하세요.)
  • 변경 사항에 대한 테스트를 했습니다.(버그 수정/기능에 대한 테스트).

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f8d5ac0179

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


@Transactional
public int deactivateAllActiveMembers() {
return userRepository.bulkUpdateMemberStatus(MemberStatus.ACTIVE, MemberStatus.INACTIVE);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Revoke refresh tokens when deactivating members

When this seasonal deactivation runs for ROLE_USER accounts that are currently logged in, their stored refresh tokens remain valid even though login now rejects non-ACTIVE users. LoginService.refresh only checks that the user is not deleted and that the Redis refresh token matches before issuing a new access token, so inactive members can keep refreshing until the refresh token expires; either invalidate the affected refresh keys here or make refresh enforce the same ACTIVE check.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한국어로 코멘트해

@BongSeongEun BongSeongEun merged commit 8102a72 into dev Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants