WIP: Use only CATKIN_IGNORE to ignore packages, not COLCON_IGNORE/AMENT_IGNORE#688
Merged
timonegk merged 1 commit intocatkin:mainfrom Apr 3, 2025
Merged
Conversation
Member
|
By the way, because I just noticed that I never responded to this PR: I like your suggestion, but we have to wait for the merge of the other pull request, of course. |
rhaschke
approved these changes
Apr 3, 2025
Contributor
@timonegk: ros-infrastructure/catkin_pkg#307 was merged meanwhile. |
Member
|
@rhaschke thanks for the update, I will merge it in the evening and create a new release. |
timonegk
force-pushed
the
ignore_only_catkin_ignore
branch
from
0ae3953 to
3e11efb
Compare
timonegk
force-pushed
the
ignore_only_catkin_ignore
branch
from
3e11efb to
aa87b7e
Compare
Member
|
@wjwwood I just tagged 0.9.5 and pushed it to PyPI. I don't know if you still do the apt releases, but if you do, could you please pull the trigger there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My use case: I have a shared source space in which both ROS1 and ROS2 packages reside (the migration to ROS2 is ongoing). Now I want to build the ROS1 packages using catkin_tools, same as before, and the ROS2 packages using colcon. To do this, I place CATKIN_IGNORE files in the ROS2 packages, and COLCON_IGNORE files in the ROS1 packages.
Problem: catkin_tools/catkin_pkg ignores the ROS1 packages due to an existing COLCON_IGNORE.
I think catkin_tools should ignore ROS1 packages only when there is a CATKIN_IGNORE file present, and not when COLCON_IGNORE/AMENT_IGNORE is present.
This PR depends on a PR in catkin_pkg: ros-infrastructure/catkin_pkg#307