Fix bugs found on restart tests: advancer snapshot sync, claimer and prt in flight transactions

[vfusco]

No description provided.

[Copilot]

Pull request overview

This PR hardens restart-related behavior across the node’s synchronization/settlement/claiming flows and updates the integration test harness to manage the node lifecycle directly from TestMain, enabling restart/snapshot-policy coverage in a consistent way.

Changes:

• Add end-to-end integration suites for node restart scenarios and snapshot policy behavior (Authority + PRT), including test-managed node restarts.
• Improve robustness of PRT settlement/tournament join and Claimer behavior around “already submitted/joined/settled” cases after restart (lost in-memory “in-flight” maps).
• Adjust machine synchronization logic to avoid false mismatches when DB pagination returns 0 rows at high offsets; update compose/test scripts to match the new test-managed node lifecycle.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
test/integration/snapshot_policy_test.go	New suite to validate snapshot loading across restarts under different snapshot policies (Authority + PRT).
test/integration/restart_test.go	New suite to validate multi-app processing continuity across node restart (Authority + PRT).
test/integration/node_helpers_test.go	Introduces shared node subprocess management helpers (start/stop/health).
test/integration/main_test.go	Moves node lifecycle management into TestMain and sets up temp log/snapshots paths.
test/compose/compose.integration.yaml	Removes compose-managed node service; relies on TestMain-managed node inside test container.
scripts/run-integration-tests.sh	Simplifies entrypoint (node now started by TestMain) and prints node log on exit.
pkg/machine/implementation_test.go	Stabilizes deadline-exceeded context test by using an already-expired deadline.
internal/prt/util.go	Adds ABI-based revert-reason decoding helper for Error(string) revert payloads.
internal/prt/util_test.go	Adds unit tests for revert-reason decoding helper.
internal/prt/types.go	Adds constants used for PRT revert-reason handling.
internal/prt/prt.go	Adds on-chain pre-checks + revert-based fallbacks for duplicate settle/join after restart.
internal/prt/itournament_adapter.go	Adds adapter method to detect already-joined commitments on-chain.
internal/prt/idaveconsensus_adapter.go	Adds adapter method to detect already-settled epochs (per current approach).
internal/manager/instance.go	Moves processed-input validation earlier to avoid OFFSET/COUNT window-function edge case.
internal/manager/instance_test.go	Updates mock behavior and expected error message to match PostgreSQL semantics and new error text.
internal/claimer/claimer.go	Handles NotFirstClaim gracefully after restart; adds helper for epoch-only matching.
internal/claimer/blockchain.go	Broadens ClaimAccepted event scan to match epoch identity (app + lastBlock) even if root differs (Quorum outvoting detection).
internal/claimer/claimer_test.go	Adds coverage for NotFirstClaim handling (Authority benign vs Quorum inoperable).
Makefile	Simplifies local integration flow (no longer starts node in Makefile) and kills stale node on port 10000.
Dockerfile	Ensures log directory exists/owned correctly for named volume pre-population in tester image.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.