Fix the algorithm is not correct when the number of elements is not evenly divisible by 10 or 2#1
Open
nguyenvuduc wants to merge 1 commit intocarol-coded:masterfrom
Open
Fix the algorithm is not correct when the number of elements is not evenly divisible by 10 or 2#1nguyenvuduc wants to merge 1 commit intocarol-coded:masterfrom
nguyenvuduc wants to merge 1 commit intocarol-coded:masterfrom
Conversation
…venly divisible by 10 or 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Carol-He,
I think it is a brilliant idea with a minor flaw.
I found the CUDA algorithm will miss the remainder part when the number of elements is not evenly divisible by the factor (10 or 2) that was hardcoded in the CUDA kernel. I have fixed it, and I would like to contribute to your original work.
Thank you.