Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions api/config/observability.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
// ObservabilityPublisher
type ObservabilityPublisher struct {
ArizeSink ArizeSink
BigQuerySink BigQuerySink
MaxComputeSink MaxComputeSink
KafkaConsumer KafkaConsumer
ImageName string
Expand Down Expand Up @@ -46,14 +45,6 @@ func (az ArizeSink) IsEnabled(modelSerial string) bool {
return false
}

// BigQuerySink
type BigQuerySink struct {
Project string
Dataset string
TTLDays int
Enabled bool
}

// MaxComputeSink
type MaxComputeSink struct {
Project string
Expand Down
6 changes: 0 additions & 6 deletions api/pkg/observability/deployment/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,6 @@ type ArizeSink struct {
SpaceKey string `yaml:"space_key"`
}

type BigQuerySink struct {
Project string `yaml:"project"`
Dataset string `yaml:"dataset"`
TTLDays int `yaml:"ttl_days"`
}

type MaxComputeSink struct {
Project string `yaml:"project"`
Dataset string `yaml:"dataset"`
Expand Down
14 changes: 2 additions & 12 deletions api/pkg/observability/deployment/deployment.go
Original file line number Diff line number Diff line change
Expand Up @@ -262,16 +262,6 @@ func (c *deployer) applySecret(ctx context.Context, data *models.WorkerData) (se

func (c *deployer) createSecretSpec(data *models.WorkerData) (*corev1.Secret, error) {
observationSinks := []ObservationSink{}
if c.consumerConfig.BigQuerySink.Enabled {
observationSinks = append(observationSinks, ObservationSink{
Type: BQ,
Config: BigQuerySink{
Project: c.consumerConfig.BigQuerySink.Project,
Dataset: c.consumerConfig.BigQuerySink.Dataset,
TTLDays: c.consumerConfig.BigQuerySink.TTLDays,
},
})
}
if c.consumerConfig.MaxComputeSink.Enabled {
observationSinks = append(observationSinks, ObservationSink{
Type: MaxCompute,
Expand Down Expand Up @@ -429,7 +419,7 @@ func (c *deployer) createDeploymentSpec(data *models.WorkerData, secretName stri
},
},
}
podSpecWithIdentity := enrichIdentityToPod(podSpec, c.consumerConfig.ServiceAccountSecretName, []string{workerContainer})

numReplicas := c.consumerConfig.Replicas
if data.ResourceRequest != nil && data.ResourceRequest.Replica > 0 {
numReplicas = data.ResourceRequest.Replica
Expand Down Expand Up @@ -458,7 +448,7 @@ func (c *deployer) createDeploymentSpec(data *models.WorkerData, secretName stri
PublisherRevisionAnnotationKey: strconv.Itoa(data.Revision),
},
},
Spec: podSpecWithIdentity,
Spec: podSpec,
},
},
}, nil
Expand Down
43 changes: 9 additions & 34 deletions api/pkg/observability/deployment/deployment_test.go

Large diffs are not rendered by default.

55 changes: 0 additions & 55 deletions api/pkg/observability/deployment/identity.go

This file was deleted.

Loading
Loading