Fix crash on invalid directive locations in playground#231
Closed
captbaritone wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for grats canceled.
|
The playground crashed with an unhandled GraphQLError when using invalid directive locations like `DIRECTIVE_DEFINITION`. This happened because `instanceof GraphQLError` failed in the bundled environment due to duplicate module instances. Fix by replacing `parser.parseDirectiveLocation()` with `parseName()` and validating against the DirectiveLocation enum after parsing. Also use `err.name === "GraphQLError"` instead of `instanceof` for robustness in bundled environments. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
captbaritone
force-pushed
the
directive-location-bug
branch
from
9985342 to
95640fa
Compare
Owner
Author
|
Replaced by #232 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GraphQLErrorwhen using invalid directive locations likeDIRECTIVE_DEFINITION, becauseinstanceof GraphQLErrorfailed in the bundled environment (duplicate module instances)parser.parseDirectiveLocation()with manualparseName()+ validation against theDirectiveLocationenum, and switched toerr.name === "GraphQLError"check for robustnessTest plan
directiveOnDirectiveDefinitionLocation.invalid.tsdefineCustomDirectiveLocationInvalidsnapshot with improved error message🤖 Generated with Claude Code