Fix no_std error trait implementation#552
Closed
elagil wants to merge 1 commit intocapnproto:masterfrom
elagil:fix_core_error_trait
Closed
Fix no_std error trait implementation#552elagil wants to merge 1 commit intocapnproto:masterfrom elagil:fix_core_error_trait
no_std error trait implementation#552elagil wants to merge 1 commit intocapnproto:masterfrom
elagil:fix_core_error_trait
Conversation
Member
|
Ah, I suppose that rust-lang/rust#99917 made this possible. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #552 +/- ##
==========================================
+ Coverage 51.64% 52.41% +0.77%
==========================================
Files 69 70 +1
Lines 33735 34615 +880
==========================================
+ Hits 17422 18144 +722
- Misses 16313 16471 +158 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
I guess bumping the rust version for the package would be required. Is that acceptable? |
Member
|
I added the "Breaking Change" label to this PR. We should include this when we bump the version to v0.21.0. |
Member
|
rebased onto master in 7f5c15d |
Author
|
Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell, the
Errortrait is not fully implemented forno_std. This should fix it.