change parameter to be more flexible #114
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you change the commit message to highlight the breaking change by using the convetional-commit standard? https://github.com/caplin/caplin-dev-tools#releasing-packages |
JTMCaplin
force-pushed
the
FXST-3547-get-build-numbers-working-correctly
branch
from
05466c5 to
cde2622
Compare
BREAKING CHANGE: master branch name option has changed to dontAppendBranchName. When set to true branch name won't be added to the artifact name. closes FXST-3547
JTMCaplin
force-pushed
the
FXST-3547-get-build-numbers-working-correctly
branch
from
cde2622 to
45696c2
Compare
amunozcap
approved these changes
Jun 13, 2019
Contributor
|
@JTMCaplin do we still want this merged? |
Contributor
Author
|
Contributor
Author
|
I hope that didn't fuck things. Yes we still want this merged. |
Contributor
|
@JTMCaplin is there a JIRA that describes what we are aiming for here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.