feat(ios): same behavior as Android for code.#284
Open
bertrand-sifre wants to merge 2 commits into
Open
Conversation
|
Just tested, the changes do the job. @moberwasserlechner hey, is there a way to proceed with the PR? |
Author
|
Thanks for your feedback! Feel free to use my personal build in your project by adding this dependency: It's been a while since this repository was last updated. @tafelnl , maybe you could help us out? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the plugin returns the error ERR_NO_AUTHORIZATION_CODE on iOS, even when the authorization code is correctly present in the redirect URL.
Issues #199 and #279 already pointed out that the authorization code was not properly extracted or recognized in some cases.
I’m not an iOS or CapacitorJS expert — I’m just a MacGyver. 🚀