Use Community Toolkit's ObservableValidator as the base class for Screen#397
Open
alexhelms wants to merge 1 commit intocanton7:developfrom
Open
Use Community Toolkit's ObservableValidator as the base class for Screen#397alexhelms wants to merge 1 commit intocanton7:developfrom
alexhelms wants to merge 1 commit intocanton7:developfrom
Conversation
…een. - Screen derives from ObservableValidator. - Replace SetAndNotify with SetProperty. - Remove PropertyChangedDispatcher. - Remove PropertyChangedBase and use ObservableObject in its place. - Remove ValidatingModelBase. - Remove IValidationAdapter. - Remove IModelValidator. - Fix up tests. - Remove .NET 4.5.2, dotnet 3.0, and dotnet 3.1 target frameworks. - Add .NET 4.6.2, dotnet 6, and dotnet 8 target frameworks required for Community Toolkit.
Author
|
Pinging this PR as it has been a while and I have a use case for this :) Thanks! |
Owner
|
Sorry, I haven't had much time. Hopefully soon! |
Author
|
Sorry to bug you again, do you think you'll have a chance to look at this soon? Thanks! |
Author
|
Any chance you could take a look at this soon? I'd like to move forward with Community Toolkit MVVM integration without having to fork. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #396 for discussion.