Skip to content

CIP-104: Daml: Reward assignment interface#5059

Merged
dfordivam merged 34 commits into
mainfrom
dfordivam/cip-104-reward-sharing-daml-draft
May 29, 2026
Merged

CIP-104: Daml: Reward assignment interface#5059
dfordivam merged 34 commits into
mainfrom
dfordivam/cip-104-reward-sharing-daml-draft

Conversation

@dfordivam
Copy link
Copy Markdown
Contributor

@dfordivam dfordivam commented Apr 16, 2026 •
edited
Loading

Add splice-api-reward-assignment-v1
Fixes #5686

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@dfordivam dfordivam force-pushed the dfordivam/cip-104-reward-sharing-daml-fixes branch 3 times, most recently from 73d4ebd to 8e44757 Compare April 20, 2026 04:33
@dfordivam dfordivam force-pushed the dfordivam/cip-104-reward-sharing-daml-fixes branch 3 times, most recently from e29984b to ee042bf Compare May 5, 2026 09:00
Base automatically changed from dfordivam/cip-104-reward-sharing-daml-fixes to dfordivam/cip-104-sv-app-rewards May 6, 2026 08:47
@dfordivam dfordivam force-pushed the dfordivam/cip-104-sv-app-rewards branch 2 times, most recently from 28c429f to 2ba72d8 Compare May 22, 2026 07:51
@dfordivam dfordivam force-pushed the dfordivam/cip-104-reward-sharing-daml-draft branch from 85ef8f9 to 6837d70 Compare May 26, 2026 07:34
meiersi-da
meiersi-da reviewed May 26, 2026
View reviewed changes
Comment thread daml/splice-wallet/daml/Splice/Wallet/MintingDelegation.daml
meiersi-da
meiersi-da reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@meiersi-da meiersi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

Comment thread daml/splice-amulet/daml/Splice/Amulet.daml Outdated
Comment thread daml/splice-api-reward-assignment-v1/daml/Splice/Api/RewardAssignmentV1.daml Outdated
Comment thread daml/splice-wallet/daml/Splice/Wallet/MintingDelegation.daml
Comment thread daml/splice-amulet-test/daml/Splice/Scripts/TestRewardAccountingV2.daml
@dfordivam dfordivam force-pushed the dfordivam/cip-104-sv-app-rewards branch from 2ba72d8 to cc01bce Compare May 27, 2026 02:41
@dfordivam dfordivam force-pushed the dfordivam/cip-104-reward-sharing-daml-draft branch from 6837d70 to 05b694c Compare May 27, 2026 05:19
@dfordivam dfordivam changed the title [DRAFT] CIP-104: Daml: Reward assignment interface CIP-104: Daml: Reward assignment interface May 27, 2026
@dfordivam dfordivam marked this pull request as ready for review May 27, 2026 07:05
dfordivam
dfordivam commented May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@dfordivam dfordivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meiersi-da This PR now ready for review. The following steps mentioned in the doc need to happen after the release has been cut right?
https://github.com/canton-network/splice/blob/main/DEVELOPMENT.md#maintaining-daml-interfaces

Comment thread docs/src/release_notes_upcoming.rst
Comment thread docs/src/app_dev/daml_api/index.rst
Comment thread ...enerator/src/main/scala/org/lfdecentralizedtrust/splice/darutils/DarResourcesGenerator.scala
meiersi-da
meiersi-da requested changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@meiersi-da meiersi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. I found one hard blocker for the merge. Should be easy to fix though.

Comment thread ...enerator/src/main/scala/org/lfdecentralizedtrust/splice/darutils/DarResourcesGenerator.scala
Comment thread daml/splice-api-reward-assignment-v1/daml/Splice/Api/RewardAssignmentV1.daml Outdated
Comment thread daml/splice-api-reward-assignment-v1/daml/Splice/Api/RewardAssignmentV1.daml Outdated
Comment thread daml/splice-api-reward-assignment-v1/daml/Splice/Api/RewardAssignmentV1.daml
Comment thread docs/src/app_dev/daml_api/index.rst
Comment thread docs/src/release_notes_upcoming.rst
Comment thread daml/splice-amulet/daml/Splice/Amulet.daml Outdated
@dfordivam dfordivam force-pushed the dfordivam/cip-104-reward-sharing-daml-draft branch 2 times, most recently from bd682f1 to 920e819 Compare May 28, 2026 02:21
meiersi-da
meiersi-da approved these changes May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@meiersi-da meiersi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Base automatically changed from dfordivam/cip-104-sv-app-rewards to main May 29, 2026 01:40
dfordivam added 8 commits May 29, 2026 01:44
@dfordivam
Revert "Remove beneficiary field from RewardCouponV2"
0a1d579 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Add splice-api-reward-assignment-v1
e7689c4 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Build.sbt splice-api-reward-assignment-v1
8271e47 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
docs splice-api-reward-assignment-v1
d9551dc 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
interface for RewardCouponV2
57c82f8 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Use weight: Decimal
606e8b4 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Do batched process of coupons
355dc70 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Return coupons grouped by party
3762a52 
Signed-off-by: Divam <dfordivam@gmail.com>
dfordivam added 26 commits May 29, 2026 01:44
@dfordivam
Add MintingDelegation_AssignAndMint
0b92403 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Use submit, fix warning
846c490 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Rename 'weights' to 'percentages'
b713a7a 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Test orig coupon archival too
39d3b47 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Fix daml data-dependencies, decoder,sdk-version; add header
3a37442 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Add new splice-api-reward-assignment-v1-1.0.0.dar
053663b 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Update dars
99d3c15 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Update dars.lock
2e8c2ca 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Add splice-api-reward-assignment-v1 to DarResourcesGenerator
891cd8b 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Update DarResources.scala
43a8946 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Fix for lint
89e4355 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
More fixes
71af251 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Update dars
6cc6a97 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Update lock
2e78c34 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Update DarResources.scala
ae57b33 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Update dars.lock
996c1d0 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Add to release-notes
eb29c75 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Refer to docs
d78e55c 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
[ci]
768d436 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Make interface beneficiary Optional
20b17dc 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Update dars
2ec76bb 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Update lock
7dce09f 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Update DarResources.scala
0e968ef 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Fix package-lock.json
05b58f5 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
[static]
5880e88 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
[ci]
d372f55 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam dfordivam force-pushed the dfordivam/cip-104-reward-sharing-daml-draft branch from 1ac6e98 to d372f55 Compare May 29, 2026 01:44
@dfordivam dfordivam merged commit edb6e06 into main May 29, 2026
65 checks passed
@dfordivam dfordivam deleted the dfordivam/cip-104-reward-sharing-daml-draft branch May 29, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meiersi-da meiersi-da meiersi-da approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Daml: Add reward assignment interface package + minting-delegation support

2 participants

@dfordivam @meiersi-da