Skip to content

Conversation

@kiya956
Copy link
Contributor

@kiya956 kiya956 commented Dec 23, 2025

We default use test_data username/password, while test_data is not defined, fallback to use provision_data username/password not just "ubunut"/"ubuntu"

Description

We default use test_data username/password, while test_data is not defined, fallback to use provision_data username/password not just "ubunut"/"ubuntu"

Resolved issues

Solving wrong userame/password while test_data is not defined.

Documentation

Web service API changes

Tests

  1. provision imx8mp-pdk with test_data is defined and verified username/password is correct
  2. provision imx8mp-pdk without test_data and verified that we fallback to use username/password in provision_data

@kiya956 kiya956 requested a review from a team as a code owner December 23, 2025 02:53
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.42%. Comparing base (accf330) to head (a9ad6ff).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #855      +/-   ##
==========================================
+ Coverage   71.38%   71.42%   +0.03%     
==========================================
  Files         108      108              
  Lines        9674     9686      +12     
  Branches      860      860              
==========================================
+ Hits         6906     6918      +12     
  Misses       2595     2595              
  Partials      173      173              
Flag Coverage Δ *Carryforward flag
agent 72.85% <ø> (ø) Carriedforward from accf330
cli 87.90% <ø> (ø) Carriedforward from accf330
device 55.34% <100.00%> (+0.12%) ⬆️
server 87.71% <ø> (ø) Carriedforward from accf330

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
Agent 72.85% <ø> (ø)
CLI 87.90% <ø> (ø)
Common ∅ <ø> (∅)
Device Connectors 55.34% <100.00%> (+0.12%) ⬆️
Server 87.71% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

We default use test_data username/password, while test_data is not defined
fallback to use provision_data username/password but just "ubunut"/"ubuntu"

Signed-off-by: ChunAn Wu <an.wu@canonical.com>
@kiya956 kiya956 force-pushed the default_uname_passwd branch from d733160 to a9ad6ff Compare December 23, 2025 05:15
Copy link

@artiepoole artiepoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kiya956 , this seems to solve my problem exactly.

@p-gentili p-gentili self-requested a review January 7, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants