Skip to content

Conversation

@letFunny
Copy link
Collaborator

@letFunny letFunny commented Sep 9, 2025

The idea is that the reference for maintenance will be shown when using unmaintainted or unstable releases, see canonical/chisel#238 (comment) for context.

The goal of this PR is to write down all ideas and to see if the reference is a good page to show in Chisel's output (again, see github comment above for context).

@letFunny letFunny requested a review from cjdcordeiro September 9, 2025 10:00
@letFunny letFunny force-pushed the unmaintained-releases branch from 64d331c to b316376 Compare September 9, 2025 10:07
@letFunny letFunny force-pushed the unmaintained-releases branch from b316376 to 4776eed Compare September 9, 2025 10:08
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is v2 specific right? So I think we need to also update the top of chisel.yaml.md, to add and the format version, and maybe add a column to these new attributes, to state that they are only available in v2

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @letFunny . I think we still need the change related to the introduction of v2

@letFunny
Copy link
Collaborator Author

Thanks for the changes @letFunny . I think we still need the change related to the introduction of v2

I misunderstood your other comment then in MM. I thought we were going to add versioning to the docs in the sense of browsing docs per chisel version. I will add a column here for compatibility, maybe saying >= v2.

@letFunny
Copy link
Collaborator Author

letFunny commented Sep 15, 2025

@cjdcordeiro I have added the attribute "compatibility" for all values with either:

  • v1 if it is deprecated like "default".
  • >= v1.
  • >= v2.

Please tell me what you think. An alternative would be to only include for fields where it is not the default but I think it is better to be consistent and put it everywhere.

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nice, thanks!

Y the docs versioning is a separate complement, since it covers anything within Chisel (e.g. CLI changes, UX changes, etc.) while this part here is just about the chisel.yaml.

I'm a bit concerned about the maintainability of these tables, cause as we add/remove stuff, it will be really easy to mess up the compatibilities. I wish this could be generated from code, but it's good enough for now.

Thanks again

@cjdcordeiro
Copy link
Collaborator

Feel free to merge once the Chisel counterpart is merged too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants