Skip to content

Conversation

@tomli380576
Copy link
Contributor

@tomli380576 tomli380576 commented Jan 16, 2026

Description

There was an issue with $CHECKBOX_RUNTIME having multiple paths at runtime and when passed to either Path() or plain strings, will cause the resulting paths to be unusable. This PR fixes this problem by explicitly constructing CHECKBOX_RUNTIME.

Resolved issues

$CHECKBOX_RUNTIME looks like this:

$ echo $CHECKBOX_RUNTIME

/snap/checkbox24/1417 /snap/checkbox/20486/checkbox-runtime /snap/checkbox/20486/providers/checkbox-provider-certification-client /snap/checkbox/20486/providers/checkbox-provider-certification-server /snap/checkbox/20486/providers/checkbox-provider-checkbox /snap/checkbox/20486/providers/checkbox-provider-docker /snap/checkbox/20486/providers/checkbox-provider-gpgpu /snap/checkbox/20486/providers/checkbox-provider-resource /snap/checkbox/20486/providers/checkbox-provider-sru /snap/checkbox/20486/providers/checkbox-provider-tpm2

but we only want /snap/checkbox/20486/checkbox-runtime, which can be constructed with $SNAP/checkbox-runtime.

Also fixed the issue with CHECKBOX_RUNTIME / GLMARK2_DATA_PATH resolving to just GLMARK2_DATA_PATH. Originally GLMARK2_DATA_PATH had a leading slash which would override CHECKBOX_RUNTIME when using the truediv operator /.

Documentation

Tests

@tomli380576 tomli380576 requested a review from Copilot January 16, 2026 03:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where $CHECKBOX_RUNTIME environment variable contains multiple space-separated paths, causing problems when used to construct Path objects. The fix explicitly constructs the correct checkbox runtime path instead of relying on the multi-path environment variable.

Changes:

  • Updated path construction in gl-support test to use an explicit hardcoded path instead of concatenating CHECKBOX_RUNTIME with GLMARK2_DATA_PATH

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tomli380576 tomli380576 changed the title Fix bad path objects in gl-support and reboot tests(Bugfix) Fix bad CHECKBOX_SUPPORT value in gl-support and reboot tests(Bugfix) Jan 16, 2026
@tomli380576 tomli380576 requested a review from Copilot January 16, 2026 04:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tomli380576 tomli380576 changed the title Fix bad CHECKBOX_SUPPORT value in gl-support and reboot tests(Bugfix) Fix bad CHECKBOX_RUNTIME value in gl-support and reboot tests (Bugfix) Jan 16, 2026
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.48%. Comparing base (4ace22e) to head (d921c87).

Files with missing lines Patch % Lines
providers/base/bin/gl_support.py 42.85% 3 Missing and 1 partial ⚠️
providers/base/bin/reboot_check_test.py 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2292      +/-   ##
==========================================
- Coverage   54.49%   54.48%   -0.02%     
==========================================
  Files         409      409              
  Lines       43970    43977       +7     
  Branches     8100     8104       +4     
==========================================
- Hits        23961    23960       -1     
- Misses      19190    19196       +6     
- Partials      819      821       +2     
Flag Coverage Δ
provider-base 31.39% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants