-
Notifications
You must be signed in to change notification settings - Fork 73
Fix bad CHECKBOX_RUNTIME value in gl-support and reboot tests (Bugfix) #2292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an issue where $CHECKBOX_RUNTIME environment variable contains multiple space-separated paths, causing problems when used to construct Path objects. The fix explicitly constructs the correct checkbox runtime path instead of relying on the multi-path environment variable.
Changes:
- Updated path construction in gl-support test to use an explicit hardcoded path instead of concatenating
CHECKBOX_RUNTIMEwithGLMARK2_DATA_PATH
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2292 +/- ##
==========================================
- Coverage 54.49% 54.48% -0.02%
==========================================
Files 409 409
Lines 43970 43977 +7
Branches 8100 8104 +4
==========================================
- Hits 23961 23960 -1
- Misses 19190 19196 +6
- Partials 819 821 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
There was an issue with
$CHECKBOX_RUNTIMEhaving multiple paths at runtime and when passed to eitherPath()or plain strings, will cause the resulting paths to be unusable. This PR fixes this problem by explicitly constructing CHECKBOX_RUNTIME.Resolved issues
$CHECKBOX_RUNTIME looks like this:
but we only want /snap/checkbox/20486/checkbox-runtime, which can be constructed with
$SNAP/checkbox-runtime.Also fixed the issue with
CHECKBOX_RUNTIME / GLMARK2_DATA_PATHresolving to just GLMARK2_DATA_PATH. Originally GLMARK2_DATA_PATH had a leading slash which would override CHECKBOX_RUNTIME when using the truediv operator/.Documentation
Tests