Jenkins pipelines#152
Conversation
andrei-polukhin
left a comment
andrei-polukhin
left a comment
There was a problem hiding this comment.
LGTM from the Jenkins pseudo-code side. Candid logic should be checked separately.
Thanks for working on this!
| // String proxyAddress = 'http://squid.internal:3128' | ||
| // String proxyAddress = ' ' |
| ], | ||
| userRemoteConfigs: [ | ||
| [ | ||
| credentialsId: '054810bf-9336-43b2-b9ed-e45dec6c31d2', |
There was a problem hiding this comment.
Cannot we use credentialsId: 'commercial-systems-bot'? I cannot understand what this credential is for 🤷
| script { | ||
| checkout changelog: false, poll: false, scm: [ | ||
| $class: 'GitSCM', | ||
| branches: [[name: "*/test"]], |
There was a problem hiding this comment.
We will have master on production, right?
| } | ||
| post { | ||
| always { | ||
| node('worker-3') { |
There was a problem hiding this comment.
There is slave-2 for agent, but worker-3 in post - is it to distribute load equally?
| lxc.s('sudo apt-get update') | ||
| lxc.s('sudo apt install make') | ||
| lxc.s('sudo apt-get install build-essential autoconf python-dev-is-python3 -y') // GCC for CGO | ||
| usr = "${env.GITHUB_PAT_AUTH_USR}" |
There was a problem hiding this comment.
usr is always canonical, correct?
| // String proxyAddress = 'http://squid.internal:3128' | ||
| // String proxyAddress = ' ' |
There was a problem hiding this comment.
Should we uncomment this on production?
| echo "error occured: ${err}" | ||
| } | ||
| oci.buildImage("${imageName}:latest") | ||
| sh 'env' |
| } | ||
|
|
||
| void s(String command, List<String> envArgs=[]) { | ||
| // export http_proxy=${params.http_proxy}s; \ |
There was a problem hiding this comment.
Will we use this commented code somehow?
alesstimec
force-pushed
the
test
branch
18 times, most recently
from
b9e4415 to
106f763
Compare
| stage('Archive charm') { | ||
| steps { | ||
| script { | ||
| String getCharmNamCmd = """echo "\$(cat ./charms/candid-k8s/metadata.yaml | yq .name)_ubuntu-20.04-amd64.charm" """ |
There was a problem hiding this comment.
The charm name as defined here could change if the "run-on" parameters in charmcraft.yaml are changed.
alesstimec
force-pushed
the
test
branch
9 times, most recently
from
cedfaca to
bef6510
Compare
alesstimec
force-pushed
the
test
branch
29 times, most recently
from
ba5fc5e to
40cbde6
Compare
3 participants
Description
Jenkins pipeline related changes.
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers