Skip to content

Add parameter to specify AzureAD login URL#131

Open
lbailleul wants to merge 2 commits into
canonical:masterfrom
lbailleul:master
Open

Add parameter to specify AzureAD login URL#131
lbailleul wants to merge 2 commits into
canonical:masterfrom
lbailleul:master

Conversation

@lbailleul
Copy link
Copy Markdown

Description

The new parameter loginurl allows to setup the Azure IDP to authenticate against Azure AD applications.
It still default to https://login.live.com if loginurl is not set.

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests
  • Independent change*

Copy link
Copy Markdown

@alnvdl-work alnvdl-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion.

Comment thread idp/azure/azure.go Outdated
@ijansky ijansky self-requested a review July 28, 2022 19:23
@ijansky
Copy link
Copy Markdown
Contributor

ijansky commented Jul 28, 2022

The same result can be achieved by using ADFS and setting the url key in the config file. Both ADFS and Azure AD use OpenID Connect under the hood.

For example, url: https://login.microsoftonline.com/<tenant-id>/v2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants