Remove the email option#118
Open
pedroleaoc wants to merge 2 commits into
Open
Conversation
I am not sure this is the best way to do it, but I think we should remove the option to log in via email since that's not functional atm.
alesstimec
reviewed
Mar 28, 2022
Collaborator
alesstimec
left a comment
alesstimec
left a comment
There was a problem hiding this comment.
Looking at the code the "Login with email" would only work if there was an Accept header with the "application/json" value.. When the login form is submitted, the Accept has value "text/html, application/xhtml+xml, application/xml". So i do not yet see how this was supposed to work. Let me think about it a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure this is the best way to do it, but I think we should remove the option to log in via email since that's not functional atm.