Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1375 +/- ##
=======================================
Coverage 87.06% 87.06%
=======================================
Files 93 93
Lines 6365 6365
Branches 111 111
=======================================
Hits 5542 5542
Misses 767 767
Partials 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adombeck
force-pushed
the
cargo-1.91
branch
4 times, most recently
from
fcb3c4e to
622c635
Compare
Contributor
Author
|
The |
adombeck
force-pushed
the
cargo-1.91
branch
3 times, most recently
from
849b113 to
6532279
Compare
Noble archives now include cargo-1.91. We should always try to use the latest available cargo version to avoid issues when updating our Rust dependencies.
We hardcoded the path to the cargo executable to /usr/share/cargo/bin/cargo which is the wrapper shipped by the cargo package. On Noble, that's cargo 1.75. To build with the latest cargo version (currently cargo-1.91 on Noble) we have to use the cargo wrapper below /usr/lib/rust-$VERSION instead.
Useful to debug the issue that the cargo wrapper executes the wrong cargo version
We already prepended the path to the directory of the cargo wrapper (/usr/lib/rust-<version>/share/cargo/bin/cargo) but that directory doesn't contain the rustc binary, so when the cargo wrapper called rustc, it found and used the one in /usr/bin/. WIP because we should rename the script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debian/control: Bump build dependency on cargo to 1.91
Noble archives now include cargo-1.91. We should always try to use the
latest available cargo version to avoid issues when updating our Rust
dependencies.
debian/rules: Use versioned cargo wrapper on Noble
We hardcoded the path to the cargo executable to
/usr/share/cargo/bin/cargowhich is the wrapper shipped by the cargopackage. On Noble, that's cargo 1.75. To build with the latest cargo
version (currently cargo-1.91 on Noble) we have to use the cargo wrapper
below
/usr/lib/rust-$VERSIONinstead.UDENG-8123