Fix webhook receive path to validate WebhookToken only#159
Merged
Conversation
Webhook callbacks are authenticated by a tenant-scoped WebhookToken that is generated during webhook installation. The previous receive path compared inbound X-Token headers against the Zabbix API token, which breaks alert ingestion and blurs two separate auth boundaries. This narrows /v1/receive to accept only WebhookToken values and adds handler coverage for the strict validation behavior. Constraint: Webhook authentication must remain independent from Zabbix API credentials Rejected: Fallback to instance.Token when WebhookToken is missing | preserves the buggy token coupling and weakens the auth boundary Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep inbound webhook auth isolated from outbound Zabbix API auth; do not reuse instance.Token on the receive path Tested: go test ./internal/handler -run 'TestReceiveWebhookTokenValidation|TestGetCurrentVersion|TestSystemVersion_Structure' Not-tested: Full repository test suite and lint pipeline
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v1/receivevalidateinstance.WebhookTokeninstead ofinstance.TokenWhy
Webhook callbacks use a dedicated
WebhookTokengenerated during webhook installation. The previous receive path compared inboundX-Tokenvalues against the Zabbix API token, which could reject valid webhook callbacks and coupled two independent authentication paths.Verification
go test ./internal/handler -run 'TestReceiveWebhookTokenValidation|TestGetCurrentVersion|TestSystemVersion_Structure'