Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on January 8. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
There was a problem hiding this comment.
Pull request overview
This pull request addresses two key improvements: fixing realtime sync behavior to prevent unintended API calls for non-Archivist documents, and changing dialog default selections to require explicit user opt-in.
- Refactored realtime sync hooks to use metadata-based type checking instead of parent journal name checking, improving robustness and preventing conflicts with other modules
- Changed default selection state from
truetofalsein World Setup and Sync dialogs to prevent accidental bulk operations - Removed redundant hook handlers (
createItem,createJournalEntryPage) to focus sync on Archivist-flagged documents only
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/archivist-sync.js | Refactored realtime sync hooks to use metadata-based scoping and consolidated update/delete logic for better maintainability |
| scripts/dialogs/world-setup-dialog.js | Changed default selected field from true to false in reconciliation model building |
| scripts/dialogs/sync-dialog.js | Changed default selected field from true to false for diff entries and removed trailing whitespace |
| CHANGELOG.md | Documented the fixes and behavioral changes in an Unreleased section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist
npm run lint:fixand fixed any remaining errorsTesting
Foundry VTT Version:
Game System:
Screenshots (if applicable)
Related Issues
Closes #