Skip to content

add path field and optimize bulk record fetching#88

Open
matthewpeterkort wants to merge 12 commits into
developmentfrom
feature/optimize
Open

add path field and optimize bulk record fetching#88
matthewpeterkort wants to merge 12 commits into
developmentfrom
feature/optimize

Conversation

@matthewpeterkort
Copy link
Copy Markdown
Contributor

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 26, 2026

Deploy Preview for drs-server ready!

Name Link
🔨 Latest commit d0938b0
🔍 Latest deploy log https://app.netlify.com/projects/drs-server/deploys/6a1f6e0e53e2be0008a33ebb
😎 Deploy Preview https://deploy-preview-88--drs-server.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8dae9f7977

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread cmd/migrate/main.go
Comment on lines +134 to +135
if strings.TrimSpace(targetProfile) == "" {
targetProfile = cliauth.ResolvedProfile()
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid auto-filling target profile for basic-auth imports

Auto-populating targetProfile from cliauth.ResolvedProfile() causes targetAuthFromInputs to reject valid --target-basic-user/--target-basic-password runs with --target-profile cannot be combined... whenever a root profile is set (for example via SYFON_PROFILE), even though the user did not request profile auth. This is a functional regression in migrate import for local/basic-auth targets and blocks imports in common environments where profile defaults are configured.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant