Use fmtlib for formatting messages #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
It looks like you missed a colon in |
Collaborator
|
🎉 |
* Spell notes are now an enum instead of a magic integer. * The functions are now defined in iLiving instead of cCreature, meaning they can be called on PCs. * They now use fmtlib to interpolate the name. * A creature attacking themself now prints "Name attacks themself" instead of "Name attacks Name".
…sociation list. I generally just roll with it, so here's the current list.
This file has some other things that could probably use fmtlib, but they're a bit tangled up and I don't feel like untangling them right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement over our current "string concatenation or ostringstream" approach, and it will also help a great deal in the distant future if the game ever gets localized.