Conversation
markstory
commented
Apr 4, 2019
markstory
commented
Member
- Fix version numbers.
- Remove duplicate content for requests/responses.
- Fix middleware() hook signatures.
- Fix plugin middleware example.
- Remove outdated warning for http/client.
* Fix version numbers. * Remove duplicate content for requests/responses. * Fix middleware() hook signatures. * Fix plugin middleware example. * Remove outdated warning for http/client.
dereuromark
reviewed
Apr 4, 2019
| class Application extends BaseApplication | ||
| { | ||
| public function middleware($middlewareQueue) | ||
| public function middleware(MiddlewareQueue $middleware): MiddlewareQueue |
Member
There was a problem hiding this comment.
Cant we keep the Queue prefix for clarity?
$middleware->add(Middleware) sounds wrong to me.
no inception please :P
Member
Author
There was a problem hiding this comment.
Sure. I was trying to pare down the line lengths.
dereuromark
reviewed
Apr 4, 2019
| **src/Template/Articles/view.php** add the line as shown:: | ||
|
|
||
| <!-- File: src/Template/Articles/view.ctp --> | ||
| <!-- File: src/Template/Articles/view.php --> |
Member
There was a problem hiding this comment.
templates/Articles now right?
Member
Author
There was a problem hiding this comment.
Yep, missed that as I was focused on ctp.
garas
reviewed
Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.