Skip to content

Proper queueing for macros with multiple GCD actions. #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
natis1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Proper queueing for macros with multiple GCD actions. #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions Redirect/GameHooks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,10 +237,6 @@ private unsafe bool TryActionCallback(IntPtr action_manager, ActionType type, ui
return TryActionHook.Original(action_manager, type, id, target, param, origin, unk, location);
}

// Macro queueing
// Known origins : 0 - bar, 1 - queue, 2 - macro
origin = origin == 2 && Configuration.EnableMacroQueueing ? 0 : origin;

// Actions placed on bars try to use their base action, so we need to get the upgraded version
var adjusted_id = ActionManager.MemberFunctionPointers.GetAdjustedActionId((ActionManager*)action_manager, id);

Expand All @@ -250,6 +246,18 @@ private unsafe bool TryActionCallback(IntPtr action_manager, ActionType type, ui
// The actual action that will be used
var adjusted_row = Actions.GetRow(adjusted_id);

// Macro queueing with instant exit if it cannot be cast
// Known origins : 0 - bar, 1 - queue, 2 - macro
if (origin == 2 && Configuration.EnableMacroQueueing) {
// Check status, ignoring all cooldowns, just checking if it's available or not.
var status = ActionManager.MemberFunctionPointers.GetActionStatus((ActionManager*)action_manager, type, adjusted_id, (uint)target, false, false, null);
// Do NOT queue if it's unavailable.
if (status == 572) {
return false;
}
origin = 0;
}

if (adjusted_row is null || !adjusted_row.HasOptionalTargeting()) {
return TryActionHook.Original(action_manager, type, id, target, param, origin, unk, location);
}
Expand Down