fix: cockpit iframe URL + stale stream-resource references#59
Closed
blove wants to merge 2 commits into
Closed
Conversation
…allback examples URL
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cockpit at cockpit.cacheplane.ai shows
DEPLOYMENT_NOT_FOUNDbecause the iframe loads fromexamples.stream-resource.dev(old domain).Fixes:
https://examples.cacheplane.aiincontent-bundle.tsso the cockpit works even without the Vercel env varstream-resourceGitHub URLs in Nav.tsx and Footer.tsx →cacheplane/angular.env.exampleproject nameNote: The Vercel env var
NEXT_PUBLIC_COCKPIT_RUNTIME_BASE_URLshould also be updated in the Vercel dashboard fromexamples.stream-resource.devtoexamples.cacheplane.ai.Test plan
stream-resourcereferences remain in source code