fix(chat,e2e): rename ChatSidenavScrim.close → closed + delete legacy subagents spec#487
Closed
blove wants to merge 2 commits into
Closed
fix(chat,e2e): rename ChatSidenavScrim.close → closed + delete legacy subagents spec#487blove wants to merge 2 commits into
blove wants to merge 2 commits into
Conversation
… subagents spec Two cleanups bundled: 1. Rename ChatSidenavScrimComponent's `close` output to `closed` (and update the demo-shell consumer + spec + JSDoc + generated api docs). `close` collides with the native DOM event and triggers @angular-eslint/no-output-native, which has been failing the Library — lint / test / build gate on every PR for the last week. Past-tense is idiomatic for Angular outputs (closed, opened, selected, submitted). 2. Delete cockpit/chat/subagents/angular/e2e/subagents.spec.ts (legacy orphan from pre-aimock era). It hardcoded http://localhost:4505 bypassing Playwright's baseURL, tested stale DOM structure (Orchestrator/Research Agent/Analysis Agent/Summary Agent — old cap shape), and ran silently alongside c-subagents.spec.ts because testMatch: '**/*.spec.ts' picks both up. The aimock-backed c-subagents.spec.ts is the canonical coverage. Bumps @ngaf/chat 0.0.44 → 0.0.45 (per the lib's patch-only release convention). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Prior commit's python json.dump used default ASCII escaping, which converted ~38 unrelated em-dash characters to — across the file. Rewriting with ensure_ascii=False so the api-docs.json keeps its original encoding; my ChatSidenavScrim.closed rename remains. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Closing — PR #485 already fixed this lint bug 5 hours before this PR was opened (renamed close → dismiss). My worktree was created from a stale snapshot (commit 84a753d / pre-#485). My version of the change would regress #485's dismiss back to closed. Spinning up a minimal follow-up PR with just the orphan-spec delete from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two cleanups identified in the post-Task-#4 e2e audit:
1. Library — lint failure fix (unblocks non-admin merges)
`@angular-eslint/no-output-native` has been failing the `Library — lint / test / build` gate on every PR for the last week. Root cause: `ChatSidenavScrimComponent` declared `readonly close = output()` — the name `close` collides with the native DOM `close` event.
Fix: rename `close` → `closed`. Past-tense is idiomatic for Angular outputs (matches `closed/opened/selected/submitted` pattern). Updates 4 places:
2. Delete legacy orphan spec
`cockpit/chat/subagents/angular/e2e/subagents.spec.ts` was a pre-aimock-era spec that:
The aimock-backed `c-subagents.spec.ts` is the canonical coverage.
Version bump
`@ngaf/chat`: 0.0.44 → 0.0.45 (patch-only per repo convention).
Test plan
🤖 Generated with Claude Code