test(c-messages): add aimock e2e pilot (Task #4 slice 1)#462
Closed
blove wants to merge 4 commits into
Closed
Conversation
First slice of Task #4 (aimock e2e for newly-eligible caps). Pilots the per-cap scaffold pattern on cockpit/chat/messages so the remaining 7 chat caps can be batched in a follow-up PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
11-task plan: 5 e2e/ files + project.json e2e target + ci.yml uv-sync & bash loop edits. Hand-authored single-entry fixture with recording fallback. Verifies via cockpit-e2e-wiring spec + local nx e2e. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
First slice of Task #4. Pilots the per-cap aimock e2e scaffold on cockpit/chat/messages so the remaining 7 chat caps can be batched in a follow-up PR. - e2e/ scaffold (playwright config, global-setup-impl, tsconfig, c-messages.spec.ts with 2 tests, c-messages.json fixture). - Add e2e target to project.json. - Wire cockpit/chat/messages/python uv-sync + cockpit-chat-messages- angular into ci.yml's cockpit-e2e job. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…button c-messages uses raw ChatInputComponent primitives (not the composed <chat> component). With aimock's ~30ms response, the isLoading() signal flips false before Playwright can observe the conditional Stop generating button, so sendPromptAndWait's 10s timeout fires. Replace the helper with an inline submitAndWaitForResponse that waits directly on the durable end-state: chat-message[data-role="assistant"][data-streaming="false"] Log evidence: langgraph 'Background run succeeded' in 12-32ms with HTTP 200 from aimock confirms backend + fixture work correctly — only the helper's loading-state assumption was wrong for this cap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing this pilot PR — investigation surfaced that c-messages.component.ts (and c-input) use raw |
4 tasks
blove
added a commit
that referenced
this pull request
May 19, 2026
c-messages and c-input use <chat-message-list [agent]="agent" /> standalone (intentionally, per their docstrings, to demonstrate primitive composition). The list discovers projected `<ng-template chatMessageTemplate="...">` blocks via contentChildren; with none projected, every findTemplate call returns undefined and nothing renders. Project the minimal four templates (human, ai, tool, system) matching the defaults that the composed <chat> component provides internally. Templates use ChatMessageComponent + ChatStreamingMdComponent — the public primitives — so the demos still showcase "use the primitives directly without composition" as the docstrings intend. Unblocks Task #4's c-messages aimock e2e pilot (PR #462 was closed when this bug surfaced — the e2e was timing out waiting for assistant bubbles that never rendered). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
blove
added a commit
that referenced
this pull request
May 19, 2026
#14) (#469) * docs: spec for cockpit-e2e matrix migration + submit helper Task #14 in the pre-batching cleanup arc. Replaces the sequential bash for-loop in the cockpit-e2e job with a GitHub matrix (one runner per cap, max-parallel=5, fail-fast=false, summary job preserving the "Cockpit — e2e" required-check name). Also ships submitAndWaitForResponse helper in libs/e2e-harness/src/ — addresses the leaky sendPromptAndWait pattern surfaced by PR #462 (loading-state observability fails for fast-streaming aimock paths). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs: plan for cockpit-e2e matrix migration 5-task plan: add submitAndWaitForResponse to harness, export from barrel, verify harness tests, replace cockpit-e2e job with matrix + summary, commit/push/PR. CI is the verification gate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * ci(cockpit-e2e): matrix-per-cap + submitAndWaitForResponse helper Replaces the sequential bash for-loop in the cockpit-e2e job with a GitHub Actions matrix strategy (one runner per cap, max-parallel=5, fail-fast=false). Adds a cockpit-e2e-summary job that preserves the "Cockpit — e2e" required-check name for branch protection. Drops the stale 5s sleep workaround (was a pre-per-cap-migration artifact for port 8123 collisions; each cap now binds its own pythonPort and matrix runners are fully isolated anyway). Ships submitAndWaitForResponse in libs/e2e-harness/src/ — waits directly on chat-message[data-role="assistant"][data-streaming="false"] instead of the Stop-generating button. Addresses the leaky-helper finding from PR #462: loading-state observability fails for fast-streaming aimock paths regardless of cap UI shape. Unblocks the Task #4 c-messages aimock re-pilot (and the 7-cap chat batch follow-up) by giving them a clean matrix entry pattern + a helper that doesn't depend on UI streaming state. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(cockpit-e2e-wiring): accept matrix python entry as uv-sync evidence The wiring spec previously required a literal `working-directory: cockpit/<cap>/python` step in ci.yml. After the matrix migration in this PR, that path moves into the matrix entry (`python: cockpit/...`) and the working-directory is templated as `${{ matrix.cap.python }}`. Spec now accepts either form, so matrix-templated jobs and any remaining literal-step jobs both pass the cross-check. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
blove
added a commit
that referenced
this pull request
May 19, 2026
First slice of Task #4 (aimock e2e for newly-eligible caps). Generated via scripts/generate-aimock-scaffold.ts --cap c-messages, with hand-authored fixture content and spec assertions. - 5 new e2e/ files (playwright config + global-setup-impl + tsconfig + fixtures/c-messages.json + c-messages.spec.ts). - project.json gains the e2e Nx target. - ci.yml matrix gains a c-messages entry. Two spec tests: - user message + AI response both render via submitAndWaitForResponse. - chat-message-list renders both turns (regression coverage for PR #466's primitive-demo fix). The demo was broken at the component level in PR #462 (raw ChatMessageListComponent without projected templates). PR #466 fixed that by projecting the four chat-message templates. This re-pilot verifies the aimock e2e against the fixed demo. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files
Test plan
🤖 Generated with Claude Code