fix(ci): trigger examples redeploy when libs change + redeploy apiUrl fix#46
Merged
Conversation
…piUrl fix The examples deploy change detection only checked cockpit/**/angular/ and scripts/assemble-examples.ts. Library changes (libs/angular/, libs/chat/, libs/render/) were not detected, so the apiUrl fix from PR #43 was never deployed. Now checks all three lib directories.
blove
force-pushed
the
claude/blissful-bartik
branch
from
fca8c9f to
1a206eb
Compare
blove
added a commit
that referenced
this pull request
Apr 7, 2026
The examples deploy change detection only checked cockpit/**/angular/ and scripts/assemble-examples.ts. Library changes (libs/angular/, libs/chat/, libs/render/) were not detected, so the apiUrl fix from PR #43 was never deployed. Now checks all three lib directories.
blove
added a commit
that referenced
this pull request
Apr 7, 2026
The examples deploy change detection only checked cockpit/**/angular/ and scripts/assemble-examples.ts. Library changes (libs/angular/, libs/chat/, libs/render/) were not detected, so the apiUrl fix from PR #43 was never deployed. Now checks all three lib directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes:
CI change detection: Examples deploy was only triggered by
cockpit/**/angular/andscripts/assemble-examples.tschanges. Library changes (libs/angular/,libs/chat/,libs/render/) were ignored — so the apiUrl fix from PR fix(angular): normalize relative apiUrl to absolute for LangGraph SDK #43 was built but never deployed.Trigger redeploy: Touches
assemble-examples.tsto force the examples deploy step to run, picking up the apiUrl normalization fix.Root cause
PR #43 fixed
FetchStreamTransportto normalize relative URLs, but the CI change detection didn't detectlibs/angular/changes as requiring an examples redeploy. The old code (without the fix) remained in production.Test plan
window.location.originprepended in production main.js