feat(cockpit-registry): add ag-ui product type + register ag-ui-streaming demo#450
Merged
Conversation
Thread A of Task #2 (rename + structural-consistency sweep). Registers the existing cockpit-ag-ui-streaming-angular cap in apps/cockpit/scripts/capability-registry.ts. Schema makes pythonDir + graphName optional to accommodate ag-ui's in-process FakeAgent architecture. Two consumer guards: deploy script skips no-Python caps; e2e-wiring spec guards its pythonDir checks. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks (3 code commits + 1 verification + 1 orchestrator). Each code commit touches one file; verification covers manifest count, build, test target, and 4 aimock e2es. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Schema change: pythonDir and graphName become optional to accommodate caps without a Python backend. Adds 'ag-ui' to the product union and registers the existing cockpit-ag-ui-streaming-angular cap (uses FakeAgent in-process; no LangSmith deployment). Two downstream consumers need guards (separate commits): - scripts/generate-shared-deployment-config.ts (skip when no pythonDir) - apps/cockpit/cockpit-e2e-wiring.spec.ts (guard pythonDir check) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Per the schema change in the prior commit, pythonDir is now optional. ag-ui caps (in-process FakeAgent) and any future no-Python caps need to be skipped — they have no langgraph.json to stage and contribute no graphs to the shared-dev deployment. Manifest graph count unchanged (32 graphs). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Per the registry schema change two commits prior, pythonDir is now optional. The e2e-wiring spec compares capability.pythonDir against the per-cap e2e harness's langgraphCwd; caps without pythonDir (ag-ui) don't have an e2e harness either, so the check should skip rather than fail comparing undefined to a path string. Mirrors the existing pythonPort guard pattern (already wrapped in !== undefined). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Two consumers missed in PR #450's pre-flight grep (which used `capability.pythonDir` pattern but missed `c.pythonDir`/`cap.pythonDir`): - apps/cockpit/scripts/generate-combined-langgraph.ts: TypeScript error using `c.graphName` (undefined for ag-ui) as object index - apps/cockpit/scripts/serve-example.ts: would spawn `cd undefined && uv run langgraph dev` for ag-ui-streaming Both now skip cleanly when pythonDir is absent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Thread A of Task #2 (rename + structural-consistency sweep). Threads B + C landed via PR #449.
Registers the existing `cockpit-ag-ui-streaming-angular` demo in `apps/cockpit/scripts/capability-registry.ts`. The ag-ui cap is unique in having no Python backend (uses FakeAgent in-process), so:
3 commits, one per file. Per-commit boundaries keep each change reviewable.
Test plan
What this doesn't touch
CI noise
Per the user's standing warning, parallel domain changes may turn unrelated jobs red. Cockpit gates are the real signal. Admin-merge if only unrelated jobs fail.
🤖 Generated with Claude Code