feat(cockpit-chat): welcome chips backed by recorded aimock prompts (c-tool-calls, c-subagents, c-interrupts)#445
Merged
Conversation
Audit deliverable for the suggested-prompts follow-up. Adds chips to c-tool-calls, c-subagents, c-interrupts using the exact prompt strings their aimock specs exercise. Closes the chip-vs-test drift surfaced by the audit (3 caps have proven prompts but no chips today). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6 tasks. 3 component edits (Tasks 1-3) + build verify (4) + e2e regression (5) + push/PR/merge (6, orchestrator). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds one chat-welcome-suggestion whose value exactly matches the PROMPT in cockpit/chat/tool-calls/angular/e2e/c-tool-calls.spec.ts. Users clicking the chip drive a flow guaranteed to replay from the recorded fixture (no real OpenAI hit). Closes one row of the chip-vs-test drift surfaced by the suggested- prompts audit (task #1 of the post-migration follow-up queue). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds one chat-welcome-suggestion whose value exactly matches the PROMPT in cockpit/chat/subagents/angular/e2e/c-subagents.spec.ts (`Plan a trip from LAX to JFK`). Users clicking the chip drive the recorded orchestrator → research/booking/itinerary subagent flow with no real OpenAI hit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Two chat-welcome-suggestions, one per recorded flow: - "Book UA123 (confirm)" → matches the spec's confirm-flow PROMPT. - "Book AA404 (cancel)" → matches the spec's cancel-flow PROMPT. Labels hint at the modal action (Accept vs Ignore) that produces the recorded resume path. Users clicking either chip drive a flow guaranteed to replay from the recorded fixture. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit deliverable for task #1 of the post-migration follow-up queue. Adds welcome-suggestion chips to 3 cockpit chat caps whose aimock specs already exercise specific prompts but whose UIs surface nothing to first-time users. Each chip's `value` matches the corresponding aimock spec `PROMPT` constant byte-for-byte — clicking a chip drives a flow guaranteed to replay from the recorded fixture (no real OpenAI hit).
"Book AA404 (cancel)" → `Book me on AA404.`
Pattern mirrors c-generative-ui's existing chip wiring. Other 7 chat caps (messages, input, debug, theming, threads, timeline, a2ui) don't have aimock specs yet — chips deferred until aimock specs land (task #4 in the queue).
Test plan
CI note
Parallel domain changes may be in flight that turn unrelated CI jobs red. Local 4× cockpit aimock suite passed (7 total tests); Cockpit gates are the meaningful signal.
🤖 Generated with Claude Code