ci: include scripts/rate-limit.ts in demo redeploy gating (+ trigger redeploy of #316)#317
Merged
Merged
Conversation
The Phase 3 hotfix in #316 fixed a SQL bug in scripts/rate-limit.ts but never reached production: the CI Check if demo changed step's regex only watched assemble-demo, demo-middleware, and langgraph-proxy. A rate-limit.ts change alone evaluated demo_changed=false, the deploy step was skipped, and demo.cacheplane.ai kept serving the original broken bundle. Two changes: 1. Extend the watched regex to include scripts/rate-limit.ts. 2. Touch scripts/demo-middleware.ts (a documentation comment) so THIS PR matches the existing watched paths and triggers the redeploy that picks up #316's SQL fix. Also documents the gating contract in demo-middleware.ts itself so a future engineer splitting rate-limit into multiple files knows to update the regex. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Phase 3 hotfix in #316 fixed a SQL bug in `scripts/rate-limit.ts` but never reached production. The CI `Check if demo changed` step's regex only watched assemble-demo, demo-middleware, and langgraph-proxy. A rate-limit.ts change alone evaluated `demo_changed=false`, the deploy step was skipped, and `demo.cacheplane.ai` kept serving the original broken bundle.
Verified by querying the latest Vercel deployment: still `dpl_5ZCi...` from before #316.
Fix
The doc comment also calls out the implicit coupling so future splits of rate-limit into multiple files don't silently break the gating.
Test plan
🤖 Generated with Claude Code