Skip to content

fix(rate-limit): SQL interval parameterization — Phase 3 hotfix #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blove merged 1 commit into from
May 14, 2026
Merged

fix(rate-limit): SQL interval parameterization — Phase 3 hotfix #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions scripts/rate-limit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,18 @@ if (!databaseUrl) {

const ALLOW_PASSTHROUGH: RateLimitResult = { allowed: true, retryAfterSec: 0, count: 0 };

// Pre-built `interval` literal. Splicing WINDOW_SECONDS via the tagged-template
// parameter machinery would emit `interval '$1 seconds'`, which Postgres rejects
// (parameters can't substitute inside string literals). The constant is hardcoded
// at module load instead.
const WINDOW_INTERVAL = `${WINDOW_SECONDS} seconds`;

export async function checkRateLimit(ip: string): Promise<RateLimitResult> {
if (!sql) return ALLOW_PASSTHROUGH;
try {
await sql`DELETE FROM rate_limit_events WHERE ip = ${ip} AND ts < now() - interval '${WINDOW_SECONDS} seconds'`;
await sql`DELETE FROM rate_limit_events WHERE ip = ${ip} AND ts < now() - ${WINDOW_INTERVAL}::interval`;
await sql`INSERT INTO rate_limit_events (ip, ts) VALUES (${ip}, now())`;
const rows = await sql`SELECT count(*)::int AS c FROM rate_limit_events WHERE ip = ${ip}`;
const rows = await sql`SELECT count(*)::int AS c FROM rate_limit_events WHERE ip = ${ip} AND ts > now() - ${WINDOW_INTERVAL}::interval`;
const count = (rows[0] as { c?: number } | undefined)?.c ?? 0;
return {
allowed: count <= limit,
Expand Down
Loading