ci: gate fixture drift workflow on manual dispatch only#312
Merged
Conversation
The committed fixtures are handwritten seeds, not captured from real upstream calls. Drift detection against real upstream will almost always trip the byte-size threshold until recorded fixtures land. Switch to workflow_dispatch-only and re-enable the cron when there is something real to compare against.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops the daily cron from the fixture-drift workflow.
The Phase 2a fixture (
hi.json) is a handwritten seed —{"content": "Hi! How can I help?"}— not a real captured upstream response. The drift script compares byte sizes against a fresh recording; against a handwritten seed it will almost always trip the 20% threshold and open a false-positive issue on day one.Keeps the
workflow_dispatchtrigger so the workflow stays runnable on demand. When recorded fixtures land in a later phase, re-add aschedule:block (weekly cron is a reasonable starting cadence) — the comment in the file flags this.Test plan
workflow_dispatchtrigger remains in place