fix(chat): debug toggle to bottom-left + missing sidebar launcher#308
Merged
Conversation
…ncher Two bugs found via browser smoke against demo.cacheplane.ai: - popup launcher occluded by debug toggle at same bottom-right position - chat-sidebar composition is missing the launcher button entirely Fix: move debug pill to bottom-left, add launcher to chat-sidebar. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Two UI bugs found via browser smoke against the freshly-deployed demo.cacheplane.ai: 1. **Popup launcher occluded by debug toggle.** Both rendered at position: fixed; bottom: 20px; right: 20px. Debug has z-index 990 and renders later in the DOM, so clicks at that corner hit debug, not the chat launcher. Verified via elementsFromPoint: [<button aria-label='Open chat debug'>, ..., <button class='chat-launcher-button'>]. 2. **Sidebar launcher missing entirely.** chat-popup.component.ts:62 renders <chat-launcher-button (click)='toggle()' />; chat-sidebar omitted this completely — no import, no template entry. Users hitting /sidebar mode saw an empty page with copy promising 'click the launcher button (right edge)' but no button in the DOM. Fix: - chat-debug: .launcher rule's `right: 20px` → `left: 20px`. Frees up the canonical bottom-right slot for user-facing chat launchers. - chat-sidebar: import ChatLauncherButtonComponent, register in imports[], render <chat-launcher-button (click)='toggle()' /> adjacent to the sliding panel. Mirrors the popup pattern exactly. No new unit test — integration-style tests for these compositions need a fully-faked Agent (the inner <chat> projection needs the full surface). Manual browser smoke covers the click paths. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks
blove
added a commit
that referenced
this pull request
May 14, 2026
…er (#310) The previous fix (#308) added <chat-launcher-button> to the chat-sidebar template, but the launcher itself has no inherent fixed positioning (it's a 56×56 div with `display: inline-block`). chat-popup positions its launcher via :host { position: fixed }, but chat-sidebar's :host is `display: block` to allow the content-pushes-on-open behavior. So the newly-added launcher in chat-sidebar flowed into the document at the natural position of the component — which for the demo shell ends up at (280, 1972), well off-screen. Wrap the launcher in a .chat-sidebar__launcher div with position: fixed; bottom: 1rem; right: 1rem; z-index: 30; matching chat-popup's launcher coordinates exactly. Also hide the launcher when the sidebar is open (the panel covers it and the panel has its own close button). Verified via demo.cacheplane.ai browser smoke after the previous fix. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two UI bugs surfaced by browser smoke against the freshly-deployed `demo.cacheplane.ai`:
Fix
Spec & Plan
Test plan
🤖 Generated with Claude Code