chore: add libs/* to npm workspaces; clean CSS import path for examples#302
Merged
Conversation
Root package.json `workspaces` only had `["packages/*", "apps/*"]`, so @ngaf/* libs were not symlinked into node_modules. esbuild's CSS resolver couldn't see them, forcing the chat-timeline pilot to use a 5-level relative path for its theme.css import. Adding `libs/*` to the workspaces glob and running npm install symlinks all 14 @ngaf/* libs into node_modules. The pilot now uses the package import path: @import "@ngaf/example-layouts/theme.css". Stage 2 (remaining 31 example apps) can use the clean import path from day one. Linux @next/swc-* bindings preserved (4 → 4) — npm install was additive, not a regeneration. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root `package.json` workspaces glob was `["packages/", "apps/"]` — `libs/` was missing, so `@ngaf/` libraries weren't symlinked into `node_modules`. TS imports still resolved via tsconfig `paths`, but esbuild's CSS resolver doesn't consult tsconfig — so the Stage 1 chat-timeline pilot ended up with a 5-level relative import for its `theme.css`.
Adding `libs/` to the workspaces glob and running `npm install` symlinks all 14 `@ngaf/` libs into `node_modules/@ngaf/`. The pilot's `styles.css` now uses the package import:
```css
@import "@ngaf/example-layouts/theme.css";
```
Stage 2 (remaining 31 Angular example apps) uses the clean path from day one — no per-app workaround.
Verification
Risk
Lockfile churn: `npm install` added 16 packages (workspace metadata for the libs), 545 funding pings, no `@next/swc-*` Linux bindings dropped. Minimal — additive only.
🤖 Generated with Claude Code