fix(chat): bridge defers surfaceUpdate dispatch until components have ids#269
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… ids The partial-args bridge dispatched surfaceUpdate envelopes the moment they were structurally complete (components is an array) — typically very early in streaming when the first component object had not yet streamed its id field. pickRoot then returned null and synthesis was skipped. The bridge's dispatchedCount advanced past the surfaceUpdate envelope, so subsequent pushes never retried and the surface never mounted via the live-stream path. Now: defer dispatch until pickRoot(components) returns a real string, then dispatch the surfaceUpdate + synthesised beginRendering as an atomic pair. Subsequent envelopes flow through the existing index-based dispatch loop. A real beginRendering arriving later for the same surfaceId is treated as idempotent and skip-advanced past in the dispatch loop.
blove
force-pushed
the
claude/genui-streaming-bridge-fix
branch
from
afbba74 to
3e75ad7
Compare
3 tasks
blove
added a commit
that referenced
this pull request
May 12, 2026
…rk (#271) Brings the canonical smoke checklist current with 29 PRs that landed between Phase 7 (#239) and today without checklist updates. Specifically: Updated sections: - chat-debug devtools — replaced bottom-drawer model with floating launcher + status pill + switch (PRs #249, #251) - Control palette — palette v2 (status pill, shadcn-styled panel, PR #244) - Generative UI / A2UI surfaces — single-bubble invariant (PR #255), parent-emits-envelopes architecture (PR #259), wrapped-content + tool_calls coexistence (PR #255), envelope reorder - Server-side wire format — tool_calls preserved on the final AI - Replaced 'Multi-thread' section with 'Sidenav (thread management)' reflecting the permanent semantic <nav> + Active/Archived sections (PR #253) and removing the old palette-toggled drawer model Added sections: - Cmd+K history search — palette open/search/select/close, archived result subtitle, keyboard navigation (PR #253) - Per-row thread actions — kebab menu order per state (active, pinned, archived), rename + pin/unpin + archive/unarchive + delete flows (PRs #258, #260, #267) - Thread titles — first-user-message derivation, idempotent writes, manual rename precedence (PR #242) - Progressive A2UI streaming — per-component fallback transition observable during streaming window (PRs #252, #261, #262, #268, #269) - Inline checkpoint markers — render between messages during multi-step runs (PR #243) - Responsive sidenav — viewport breakpoints, auto-collapse behavior (PR #240) Total: ~58 new check items across 6 new sections, plus rewrites to 5 existing sections. Original 333-line checklist → 391 lines / 237 check items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The partial-args bridge dispatched surfaceUpdate envelopes the moment they were "structurally complete" (components is an array) — typically very early in streaming when the first component object hadn't yet streamed its
idfield.pickRootthen returned null and synthesis was skipped. The bridge'sdispatchedCountadvanced past the surfaceUpdate envelope, so subsequent pushes never retried — the surface never mounted via the live-stream path.PR #268 fixed the backend so a2ui-partial events now reach the SSE wire (verified live: 758 events / 2.5 MB stream for a dashboard prompt), but the bridge consumed them without producing any live surface.
Fix
Option (c) from the design discussion: defer surfaceUpdate dispatch until
pickRoot(components)returns a real string, then dispatch the surfaceUpdate + synthesized beginRendering as an atomic pair. After that, continue with index-based dispatch for subsequent envelopes (dataModelUpdates, etc.).The store treats a "real" beginRendering arriving later with the same surfaceId as idempotent (it merges styles; component map unchanged), so we additionally skip-and-advance past it in the dispatch loop.
Tests
Live smoke (post-merge)