fix(chat): post-merge sidenav polish — semantic <nav> + rename close→closed#256
Merged
Conversation
…e output - chat-sidenav: replace <aside role="navigation"> with semantic <nav> (adds tabindex="-1" so Esc keydown still binds without tripping the interactive-supports-focus lint rule). - chat-history-search-palette: rename close output to closed, dropping the @angular-eslint/no-output-native suppression. Past-tense matches the convention of state outputs (opened/closed). - examples-chat-angular: switch the consumer binding to (closed). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two minor cleanups flagged in the #253 code review, deferred at that time and addressed now after browser verification.
chat-sidenav: replace<aside role=\"navigation\">with semantic<nav>(HTML5 element of choice for navigation). Addstabindex=\"-1\"so the existing Esc keydown binding still works without tripping the@angular-eslint/template/interactive-supports-focusrule.chat-history-search-palette: rename thecloseoutput toclosed, dropping the@angular-eslint/no-output-nativesuppression. Past-tense matches the convention of state outputs (opened/closed) and removes the global-window-method shadow concern.examples-chat-angular.Browser-verified via
nx serve examples-chat-angular: sidenav renders correctly indrawerandexpandedmodes, palette opens/closes via search button, Cmd+K, Esc, and scrim click; Enter selects + switches thread.Test plan
nx run chat:test— passesnx run chat:build— passesnx lint chat— passes (the new<nav tabindex=\"-1\">satisfies the interactive-supports-focus rule)nx run examples-chat-angular:build— passes🤖 Generated with Claude Code